Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpki-roots/webpki-root-certs: prepare 0.26.6, fix license data #80

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Sep 18, 2024

These crates mistakenly had license files included for Apache and MIT licenses. Both are derived works under an MPL 2.0 license

Resolves #79

Proposed release notes

  • Corrects the license file distributed with the webpki-roots and webpki-root-certs crates to properly reflect the MPL 2.0 license.

cpu added 2 commits September 18, 2024 15:49
These crates mistakenly had license files included for Apache and MIT
licenses. Both are derived works under an MPL 2.0 license.
@cpu
Copy link
Member Author

cpu commented Sep 18, 2024

@djc @ctz I'm leaning towards yanking 0.26.4 and 0.26.5 once this 0.26.6 release is published. WDYT? (Edit: convinced this is unnecessary)

Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the need to yank the old versions -- this is merely an administrative error and doesn't change the actual license they were released under.

@cpu
Copy link
Member Author

cpu commented Sep 18, 2024

this is merely an administrative error and doesn't change the actual license they were released under.

That's fair, I buy the argument that the Cargo.toml license field is more authoritative than the included license files and was set correctly:

license = "MPL-2.0"

license = "MPL-2.0"

@cpu cpu merged commit 7edc915 into rustls:main Sep 18, 2024
1 check passed
@cpu
Copy link
Member Author

cpu commented Sep 18, 2024

Sorry, forgot to add proposed release notes. Just added.

I'll wait a little bit in case anyone feels I've missed the mark on those and then complete the release.

@cpu cpu deleted the cpu-fix-root-data-license branch September 18, 2024 21:17
@cpu
Copy link
Member Author

cpu commented Sep 19, 2024

  • Pushed v0.26.6 tag
  • Published webpki-root-certs v0.26.6 at registry crates-io
  • Published webpki-roots v0.26.6 at registry crates-io
  • Created 0.26.6 GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpki-roots v0.26.4+ published with MPL-2.0 license but contains Apache-2.0 and MIT license texts
3 participants