Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add merge_group trigger to ci tasks. #104

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Jun 27, 2023

This commit adds merge_group to our CI task on triggers in preparation for enabling the merge queue feature.

Per the GitHub docs

You must use the merge_group event to trigger your GitHub Actions
workflow when a pull request is added to a merge queue.

Note: If your repository uses GitHub Actions to perform required
checks on pull requests in your repository, you need to update the
workflows to include the merge_group event as an additional trigger.
Otherwise, status checks will not be triggered when you add a pull
request to a merge queue. The merge will fail as the required status
check will not be reported. The merge_group event is separate from the
pull_request and push events.

This commit adds `merge_group` to our CI task `on` triggers in
preparation for enabling the merge queue feature.

Per the GitHub docs[0]:

> You must use the merge_group event to trigger your GitHub Actions
> workflow when a pull request is added to a merge queue.
>
> Note: If your repository uses GitHub Actions to perform required
> checks on pull requests in your repository, you need to update the
> workflows to include the merge_group event as an additional trigger.
> Otherwise, status checks will not be triggered when you add a pull
> request to a merge queue. The merge will fail as the required status
> check will not be reported. The merge_group event is separate from the
> pull_request and push events.

[0]: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue
@cpu cpu self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #104 (ba69251) into main (d38a264) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files          15       15           
  Lines        3272     3272           
=======================================
  Hits         3122     3122           
  Misses        150      150           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cpu cpu merged commit 24a5f90 into rustls:main Jun 27, 2023
@cpu cpu deleted the cpu-ci-trigger-on-merge-queue branch June 27, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants