Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crls: improve coverage of owned representation. #111

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Jul 4, 2023

tests: improve crl unit test coverage.

  • Adds coverage for the OwnedCertRevocationList representation.
  • Adds coverage for too large CRL number.

tests: generate owned client auth revocation tests.

Previously the generate.py generated tests for client auth revocation checking with CRLs used only the borrowed CRL representation. We also want equivalent coverage for the owned CRL representation that's gated by the alloc feature.

This commit updates the generator logic to also produce tests for the owned representation, gating those tests on the alloc feature.

@cpu cpu self-assigned this Jul 4, 2023
@cpu cpu mentioned this pull request Jul 4, 2023
6 tasks
@cpu
Copy link
Member Author

cpu commented Jul 4, 2023

ci / coverage (pull_request) Failing after 34s

Oops, forgot to rebase on the token change. Fixing.

cpu added 2 commits July 4, 2023 10:14
* Adds coverage for the `OwnedCertRevocationList` representation.
* Adds coverage for too large CRL number.
Previously the `generate.py` generated tests for client auth revocation
checking with CRLs used only the borrowed CRL representation. We also
want equivalent coverage for the owned CRL representation that's gated
by the alloc feature.

This commit updates the generator logic to also produce tests for the
owned representation, gating those tests on the alloc feature.
@cpu
Copy link
Member Author

cpu commented Jul 4, 2023

[2023-07-04T14:15:31.499Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Hmm, still not working even with 1f0ac40 - maybe because I'm opening this PR from a fork? I could switch to pushing branches to the main repo and opening PRs from there but that won't help outside contributors who run into this problem 🤔

@ctz
Copy link
Member

ctz commented Jul 4, 2023

Yeah apparently GH action secrets don't work for forks :( Gah

@cpu cpu added this pull request to the merge queue Jul 4, 2023
@cpu
Copy link
Member Author

cpu commented Jul 4, 2023

Queuing to merge with one +1 since this is a fairly uninteresting test-only diff.

Merged via the queue into rustls:main with commit d9b4338 Jul 4, 2023
@cpu cpu deleted the cpu-owned-crl-coverage branch July 4, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants