Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl FromDer for more types #141

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Impl FromDer for more types #141

merged 5 commits into from
Jul 31, 2023

Conversation

djc
Copy link
Member

@djc djc commented Jul 31, 2023

No description provided.

@djc djc requested review from cpu and ctz July 31, 2023 13:15
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #141 (10f25bd) into main (b7434a2) will increase coverage by 0.00%.
The diff coverage is 96.74%.

@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          16       15    -1     
  Lines        4061     4065    +4     
=======================================
+ Hits         3899     3903    +4     
  Misses        162      162           
Files Changed Coverage Δ
src/time.rs 96.05% <95.87%> (-3.95%) ⬇️
src/cert.rs 96.78% <100.00%> (ø)
src/crl.rs 99.65% <100.00%> (ø)
src/der.rs 99.36% <100.00%> (+0.71%) ⬆️
src/verify_cert.rs 95.22% <100.00%> (-0.02%) ⬇️
src/x509.rs 97.91% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🧹 ✨

@djc djc added this pull request to the merge queue Jul 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2023
@djc djc added this pull request to the merge queue Jul 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2023
@djc djc added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit aa818ab Jul 31, 2023
42 checks passed
@djc djc deleted the from-der-types branch July 31, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants