Fix build & clippy lints #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't an actual issue, but the fix is equivalent.
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 15 15
Lines 4376 4376
=======================================
Hits 4225 4225
Misses 151 151 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Aug 23, 2023
cpu
reviewed
Aug 24, 2023
| @@ -104,4 +104,4 @@ harness = false | |||
|
|
|||
| [patch.crates-io] | |||
| # TODO(XXX): Remove this once rcgen has cut a release w/ CRL support included. | |||
| rcgen = { git = 'https://github.com/est31/rcgen.git' } | |||
| rcgen = { git = 'https://github.com/est31/rcgen.git', rev = '83e548a06848d923eada1ac66d1a912735b67e79' } | |||
There was a problem hiding this comment.
Thanks, I think we can probably get a rcgen tag Soon ™️ but this is a good fix until then. In retrospect I should have included a SHA from the get-go.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.