-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract PathNode from Cert #173
Conversation
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
==========================================
+ Coverage 96.64% 96.70% +0.05%
==========================================
Files 16 17 +1
Lines 4532 4518 -14
==========================================
- Hits 4380 4369 -11
+ Misses 152 149 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this worked out nicely 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate this clean-up 🙏 Thanks!
Previously, a
Cert
type (which mostly represents a certificate) also doubled as a linked list node via the (somewhat cryptically named)ee_or_ca
field. Instead, use a linked list node type (here calledPathNode
to evoke the somewhat well-known notion of path building) that contains theCert
.Cert
construction becomes a lot more obvious and simple because it is no longer obliged to deal with the linked list, and we can draw a clean distinction between types for dealing the with the linked list path and types that just need the certificate data from aCert
.After spending some time with the path-building code, I wanted to try and improve cohesion so tacked on a bunch of commits that try to colocate related code.