Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let EndEntityCert deref to Cert #184

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Let EndEntityCert deref to Cert #184

merged 3 commits into from
Sep 21, 2023

Conversation

djc
Copy link
Member

@djc djc commented Sep 20, 2023

Avoids duplication and seems generally right. I think this would also make sense in the context of #174.

@djc djc requested review from cpu and ctz September 20, 2023 16:17
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #184 (031099f) into main (dc9c85c) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   96.53%   96.52%   -0.01%     
==========================================
  Files          19       19              
  Lines        4496     4492       -4     
==========================================
- Hits         4340     4336       -4     
  Misses        156      156              
Files Changed Coverage Δ
src/cert.rs 97.58% <40.00%> (ø)
src/end_entity.rs 100.00% <100.00%> (ø)
src/subject_name/verify.rs 91.84% <100.00%> (-0.05%) ⬇️
src/verify_cert.rs 97.35% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me 👍

@djc djc added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 12fe2bb Sep 21, 2023
54 of 56 checks passed
@djc djc deleted the deref-cert branch September 21, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants