crl: rm Budget from verify_signature fn #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Budget` type is a crate-internal detail that shouldn't be exposed outside of the crate. It only makes sense in the context of path path building. This commit removes the `Budget` argument from the public `CertRevocationList` trait's `verify_signature` fn.
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 96.50% 96.50% -0.01%
==========================================
Files 19 19
Lines 4466 4465 -1
==========================================
- Hits 4310 4309 -1
Misses 156 156
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Budgettype is a crate-internal detail that shouldn't be exposed outside of the crate. It only makes sense in the context of path path building.This commit removes the
Budgetargument from the publicCertRevocationListtrait'sverify_signaturefn.See #186 for a discussion of rejected alternative solutions.