Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_cert: add test for rejecting candidate path #197

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Oct 5, 2023

Restores test from #191 that was dropped from #174 in a rebase.

@cpu cpu self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #197 (1624365) into main (cbbf352) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   96.53%   96.73%   +0.19%     
==========================================
  Files          20       20              
  Lines        4617     4746     +129     
==========================================
+ Hits         4457     4591     +134     
+ Misses        160      155       -5     
Files Coverage Δ
src/verify_cert.rs 98.07% <100.00%> (+0.75%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry about that! It was definitely there at some point during my rebasing...

@cpu cpu added this pull request to the merge queue Oct 5, 2023
Merged via the queue into rustls:main with commit d2bdd8d Oct 5, 2023
29 checks passed
@cpu cpu deleted the cpu-restore-191 branch October 5, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants