Introduce and test ECDSA_P521_SHA512 for aws-lc-rs #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like any good PR, this is ~10 lines of actual changes plus ~100 lines of testing.
What's going on with
UNSUPPORTED_ECDSA_SHA512_SIGNATURE: this is some negative error cases changing depending whether we have a signature verification algorithm that supports ECDSA-SHA512: the error changes if you do (UnsupportedSignatureAlgorithmForPublicKey) or don't (UnsupportedSignatureAlgorithm).ref rustls/rustls#1666