benches: ignore clippy::incompatible_msrv #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes clippy findings of the form:
```
warning: current MSRV (Minimum Supported Rust Version) is `1.63.0` but this item is stable since `1.66.0`
--> benches/benchmark.rs:153:15
|
153 | c.iter(|| black_box(assert!(matches!(crl.find_serial(FAKE_SERIAL), Ok(None)))));
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: `#[warn(clippy::incompatible_msrv)]` on by default
```
We don't offer an MSRV for dev-only benchmarks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 19 19
Lines 4100 4100
=======================================
Hits 3986 3986
Misses 114 114 ☔ View full report in Codecov by Sentry. |
ctz
approved these changes
May 3, 2024
|
That feels like a false positive, even. |
|
See also: rust-lang/rust-clippy#12257 |
djc
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust 1.80 release broke the clippy task in CI with clippy findings of the form:
This commit ignores these findings under
benches/benchmark.rs. We don't offer an MSRV for dev-only benchmarks