Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: warn for clippy::use_self #263

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

cpu
Copy link
Member

@cpu cpu commented Jun 25, 2024

This was accidentally added to the allow lints instead of the warn lints in #262.

@cpu cpu self-assigned this Jun 25, 2024
@djc
Copy link
Member

djc commented Jun 25, 2024

You added it to deny instead of warn. 🤪

@cpu cpu force-pushed the cpu-fix-clippy-use-self branch from 3204176 to 82bce0b Compare June 25, 2024 13:51
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 45.28302% with 29 lines in your changes missing coverage. Please review.

Project coverage is 97.30%. Comparing base (c399cd9) to head (65d439c).

Files Patch % Lines
src/error.rs 21.62% 29 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          19       19           
  Lines        4237     4237           
=======================================
  Hits         4123     4123           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was accidentally added to the `allow` lints instead of the `warn`
lints.
@cpu cpu force-pushed the cpu-fix-clippy-use-self branch from 82bce0b to 65d439c Compare June 25, 2024 13:52
@cpu
Copy link
Member Author

cpu commented Jun 25, 2024

You added it to deny instead of warn.

😆 muttering something about needing more coffee

Fixed

src/lib.rs Show resolved Hide resolved
@cpu cpu added this pull request to the merge queue Jun 25, 2024
Merged via the queue into rustls:main with commit dba3b84 Jun 25, 2024
29 of 30 checks passed
@cpu cpu deleted the cpu-fix-clippy-use-self branch June 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants