Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare MSRV for Clippy #32

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

KamilaBorowska
Copy link
Contributor

No description provided.

@djc
Copy link
Member

djc commented Feb 6, 2023

Unfortunately rust-version is not actually supported prior to 1.56, I forget how it is handled by Cargo from earlier versions. But eventually we should definitely have this. If this doesn't work out, I think there's also a clippy config file where you can set the MSRV.

@KamilaBorowska
Copy link
Contributor Author

KamilaBorowska commented Feb 6, 2023

It's not supported, but it won't cause compilation failures, just warnings (warning: unused manifest key: package.rust-version), and they will only appear when interacting directly with the repo (not when using crate as a program dependency). Since 1.27, Cargo doesn't break when seeing rust-version key.

@codecov-commenter
Copy link

Codecov Report

Merging #32 (2be265b) into main (6d3fc32) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files          14       14           
  Lines        2536     2536           
=======================================
  Hits         2388     2388           
  Misses        148      148           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@djc
Copy link
Member

djc commented Feb 7, 2023

Alright, thanks!

@djc djc merged commit 6cf8ffd into rustls:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants