Removed IO abstraction #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindbergem
force-pushed
the
removed-io-abstraction
branch
from
f7ad5fb
to
90043c3
Compare
- No need go overboard with feature flags
eivindbergem
force-pushed
the
removed-io-abstraction
branch
2 times, most recently
from
cffa08f
to
d345bf5
Compare
- No need for wrapper struct, just take traits directly - Removed `async-std` dependency for tokio example. Tokio has IO abstractions.
eivindbergem
force-pushed
the
removed-io-abstraction
branch
from
d345bf5
to
d7beda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IOstruct is an unnecessary level of abstraction.