-
Notifications
You must be signed in to change notification settings - Fork 364
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Report soundness bug with lock_api (#483)
- Loading branch information
1 parent
af0ee09
commit 7b5e788
Showing
1 changed file
with
37 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
```toml | ||
[advisory] | ||
id = "RUSTSEC-0000-0000" | ||
package = "lock_api" | ||
date = "2020-11-08" | ||
url = "https://github.com/Amanieu/parking_lot/pull/262" | ||
categories = ["memory-corruption"] | ||
keywords = ["concurrency"] | ||
informational = "unsound" | ||
|
||
[versions] | ||
patched = [">= 0.4.2"] | ||
|
||
[affected.functions] | ||
"lock_api::MappedMutexGuard" = [">= 0.1.0"] | ||
"lock_api::MappedRwLockReadGuard" = [">= 0.1.0"] | ||
"lock_api::MappedRwLockWriteGuard" = [">= 0.1.0"] | ||
"lock_api::RwLockReadGuard" = [">= 0.1.0"] | ||
"lock_api::RwLockWriteGuard" = [">= 0.1.0"] | ||
``` | ||
|
||
# Some lock_api lock guard objects can cause data races | ||
|
||
Affected versions of lock_api had unsound implementations of the `Send` or | ||
`Sync` traits for some guard objects, namely: | ||
|
||
* MappedMutexGuard | ||
* MappedRwLockReadGuard | ||
* MappedRwLockWriteGuard | ||
* RwLockReadGuard | ||
* RwLockWriteGuard | ||
|
||
These guards could allow data races through types that are not safe to `Send` | ||
across thread boundaries in safe Rust code. | ||
|
||
This issue was fixed by changing the trait bounds on the `Mapped` guard types | ||
and removing the `Sync` trait for the `RwLock` guards. |