-
Notifications
You must be signed in to change notification settings - Fork 362
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #747 from ammaraskar/qwutils
[patched] Add advisory for double-free in qwutils
- Loading branch information
Showing
1 changed file
with
26 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
```toml | ||
[advisory] | ||
id = "RUSTSEC-0000-0000" | ||
package = "qwutils" | ||
date = "2021-02-03" | ||
url = "https://github.com/qwertz19281/rust_utils/issues/3" | ||
categories = ["memory-corruption"] | ||
keywords = ["memory-safety", "double-free"] | ||
|
||
[versions] | ||
patched = [">= 0.3.1"] | ||
|
||
[affected] | ||
functions = { "qwutils::imp::vec::VecExt::insert_slice_clone" = ["< 0.3.1"] } | ||
``` | ||
|
||
# insert_slice_clone can double drop if Clone panics. | ||
|
||
Affected versions of this crate used `ptr::copy` when inserting into the middle | ||
of a `Vec`. When ownership was temporarily duplicated during this copy, it calls | ||
the clone method of a user provided element. | ||
|
||
This issue can result in an element being double-freed if the clone call panics. | ||
|
||
Commit `20cb73d` fixed this issue by adding a `set_len(0)` call before | ||
operating on the vector to avoid dropping the elements during a panic. |