Add advisory for broken blake2 impls
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only HMAC values, since we have provided an incorrect value (twice smaller than it should be) for |
|
@newpavlov will push a fix, 1s |
BLAKE2b and BLAKE2s were implemented using the wrong block size. All versions of the `blake2` crate prior to v0.8.1 compute incorrect digests. See: RustCrypto/MACs#19
tarcieri
force-pushed
the
broken-blake2-impls
branch
from
766fa79
to
6d0db72
Compare
|
Updated to note this only impacts HMAC-BLAKE2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLAKE2b and BLAKE2s were implemented using the wrong block size. All versions of the
blake2crate prior to v0.8.1 compute incorrect digests.See: RustCrypto/MACs#19