Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct affected version range on RUSTSEC-2019-003[34] to patched at 0.1.20 #221

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

roy-work
Copy link
Contributor

@roy-work roy-work commented Jan 9, 2020

I believe these two vulnerabilities were patched at 0.1.20.

For RUSTSEC-2019-0033:

The advisory links to the bug: hyperium/http#352
In that bug, the fixing PR was hyperium/http#360
That PR merged the commit 81ceb61 to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 (commit).

For RUSTSEC-2019-0034:

This advisory is two separate GitHub issues against HeaderMap::drain,
http #354 and http #355.

For the first: the issue: hyperium/http#354
In that bug, the fixing PR was hyperium/http#357
That PR merged the commit 82d53db to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 (commit).

For the second: the issue: hyperium/http#355
In that bug, the fixing PR was hyperium/http#362
That PR merged the commit 8ffe094 to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 (commit).

…0.1.20

I believe these two vulnerabilities were patched at 0.1.20.

For RUSTSEC-2019-0033:

The advisory links to the bug: hyperium/http#352
In that bug, the fixing PR was hyperium/http#360
That PR merged the commit 81ceb61 to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 ([commit][1]).

[1]: hyperium/http@81ceb61

For RUSTSEC-2019-0034:

This advisory is two separate GitHub issues against `HeaderMap::drain`,
http rustsec#354 and http rustsec#355.

For the first: the issue: hyperium/http#354
In that bug, the fixing PR was hyperium/http#357
That PR merged the commit 82d53db to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 ([commit][2]).

[2]: hyperium/http@82d53db

For the second: the issue: hyperium/http#355
In that bug, the fixing PR was hyperium/http#362
That PR merged the commit 8ffe094 to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 ([commit][3]).

[3]: hyperium/http@8ffe094
@tarcieri
Copy link
Member

tarcieri commented Jan 9, 2020

Thanks. It looks like this is correct. Will merge when green.

@roy-work
Copy link
Contributor Author

roy-work commented Jan 9, 2020

I've also commented to the effect on the original PR: #218 (comment)

Please double check my work here, as getting the wrong has the potential side-effect of missing vulnerable packages, something we definitely don't want!

@Qwaz, since you were the original reporter, and in case you have some additional insight.

@tarcieri
Copy link
Member

tarcieri commented Jan 9, 2020

Okay, will wait for a second confirmation before merging.

@ryoqun
Copy link

ryoqun commented Jan 9, 2020

Hey, I'm a complete outsider, who is tripped on this advisory! First of all, thanks for maintaining this crate and its db!!

When reviewing this PR, this compare view is very illustrating in that http v0.1.x actually fixed the the bugs at the v0.1.20: hyperium/http@v0.1.19...v0.1.20

@tarcieri
Copy link
Member

tarcieri commented Jan 9, 2020

Ok, that seems sufficient to merge. Would still appreciate a retroactive OK from @Qwaz

@tarcieri tarcieri merged commit 4d05143 into rustsec:master Jan 9, 2020
@Qwaz
Copy link
Contributor

Qwaz commented Jan 9, 2020

Yes, it seems that the bug was fixed in v0.1.20. Thank you for correcting this error.

ryoqun added a commit to ryoqun/solana that referenced this pull request Jan 9, 2020
jstarry pushed a commit to ryoqun/solana that referenced this pull request Jan 10, 2020
ryoqun added a commit to solana-labs/solana that referenced this pull request Jan 14, 2020
mergify bot pushed a commit to solana-labs/solana that referenced this pull request Jan 14, 2020
For details see upstream PR: rustsec/advisory-db#221

(cherry picked from commit 699ca5f)

# Conflicts:
#	ci/test-checks.sh
mergify bot pushed a commit to solana-labs/solana that referenced this pull request Jan 14, 2020
For details see upstream PR: rustsec/advisory-db#221

(cherry picked from commit 699ca5f)
mvines pushed a commit to mvines/test that referenced this pull request Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants