Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add advisory for UB in crossbeam-channel 0.4.3 #425

Merged
merged 3 commits into from
Oct 11, 2020
Merged

Add advisory for UB in crossbeam-channel 0.4.3 #425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba83b81
Add advisory for UB in crossbeam-channel 0.4.3
taiki-e Oct 11, 2020
8b71717
Add categories and informational fields
taiki-e Oct 11, 2020
c764af8
Remove informational field
taiki-e Oct 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions crates/crossbeam-channel/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "crossbeam-channel"
categories = ["memory-corruption"]
date = "2020-06-26"
url = "https://github.com/crossbeam-rs/crossbeam/pull/533"

[versions]
patched = [">= 0.4.4"]
unaffected = ["< 0.4.3"]
```

# Undefined Behavior in bounded channel

The affected version of this crate's the `bounded` channel incorrectly assumes that `Vec::from_iter` has allocated capacity that same as the number of iterator elements. `Vec::from_iter` does not actually guarantee that and may allocate extra memory. The destructor of the `bounded` channel reconstructs `Vec` from the raw pointer based on the incorrect assumes described above. This is unsound and causing deallocation with the incorrect capacity when `Vec::from_iter` has allocated different sizes with the number of iterator elements.