Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx-auxil: Read on uninitialized buffer may cause UB ( gfx_auxil::read_spirv() ) #681

Merged
merged 2 commits into from
Aug 22, 2021
Merged

gfx-auxil: Read on uninitialized buffer may cause UB ( gfx_auxil::read_spirv() ) #681

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fefcc93
Report 0101-gfx-auxil to RustSec
JOE1994 Jan 25, 2021
bdcee61
add 'informational = unsound'
JOE1994 Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions crates/gfx-auxil/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "gfx-auxil"
date = "2021-01-07"
url = "https://github.com/gfx-rs/gfx/issues/3567"
categories = ["memory-exposure"]
informational = "unsound"

[versions]
patched = []
```

# Reading on uninitialized buffer may cause UB ( `gfx_auxil::read_spirv()` )

Affected versions of this crate passes an uninitialized buffer to a user-provided `Read` implementation.

Arbitrary `Read` implementations can read from the uninitialized buffer (memory exposure) and also can return incorrect number of bytes written to the buffer.
Reading from uninitialized memory produces undefined values that can quickly invoke undefined behavior.