Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on Node 20.x #16

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Run on Node 20.x #16

merged 3 commits into from
Apr 23, 2024

Conversation

clechasseur
Copy link

  • Use @clechasseur/rs-actions-core (tested on Node 20.x, more up-to-date dependencies)
  • Use @vercel/ncc (build didn't work locally with the old tool)
  • Update github-actions to use some that run on Node 20.x
  • Use .nvmrc to setup node in github actions

Hello! GitHub has recently provided Node 20.x on action runners and is soon deprecating Node 16.x. This PR moves your github action to Node 20.x as well. I did not update the version number or changelog.

Also move to @clechasseur/rs-actions-core for more up-to-date dependencies
@clechasseur
Copy link
Author

I wanted to update to the latest version of @clechasseur/rs-actions-core, but that didn't work well so I ended up updating all dependencies to recent versions. On the plus side, no more reported vulnerabilities 😄

@istellino-chub
Copy link

istellino-chub commented Feb 7, 2024

@clechasseur I really was looking into this when creating this issue #19. Can we in some way use your changes?

@clechasseur
Copy link
Author

@clechasseur I really was looking into this when creating this issue #19. Can we in some way use your changes?

I don't see why not. Part of the PR was updating dependencies to the latest versions, so that might require some re-do since they've probably been further updated since I created the PR, but aside from that everything should be OK.

I've never had feedback on the PR however, so I'd wait for some maintainer's feedback before further working on it.

@clechasseur
Copy link
Author

I've updated the PR after all to bring dependencies up-to-date. If anyone needs to, they can use this until this action is updated:

clechasseur/rustsec-audit-check@b5ade62a8d38826bb50ca4b8b9bc2a8a97f0d44d

@ross-paypay

This comment was marked as off-topic.

@tarcieri tarcieri merged commit fe0359b into rustsec:main Apr 23, 2024
@istellino-chub
Copy link

@tarcieri can we create a new release now that this is merged? so that it can be used by the people

@clechasseur clechasseur deleted the feat/node20 branch July 13, 2024 03:38
robert3005 referenced this pull request in spiraldb/vortex Sep 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [rustsec/audit-check](https://github.com/rustsec/audit-check)
| action | major | `v1.4.1` -> `v2.0.0` |

---

### Release Notes

<details>
<summary>rustsec/audit-check (rustsec/audit-check)</summary>

###
[`v2.0.0`](https://github.com/rustsec/audit-check/releases/tag/v2.0.0)

[Compare
Source](https://github.com/rustsec/audit-check/compare/v1.4.1...v2.0.0)

#### What's Changed

- Run on Node 20.x by
[@&#8203;clechasseur](https://github.com/clechasseur) in
[https://github.com/rustsec/audit-check/pull/16](https://github.com/rustsec/audit-check/pull/16)
- Remove `generate-lockfile` To Prevent Overwriting Checked-In Lock
Files by
[@&#8203;tillmann-crabnebula](https://github.com/tillmann-crabnebula)
in
[https://github.com/rustsec/audit-check/pull/20](https://github.com/rustsec/audit-check/pull/20)
- Added support for `working-directory` by
[@&#8203;ranger-ross](https://github.com/ranger-ross) in
[https://github.com/rustsec/audit-check/pull/21](https://github.com/rustsec/audit-check/pull/21)
- fix: security fix for vulnerability in `braces` library by
[@&#8203;clechasseur](https://github.com/clechasseur) in
[https://github.com/rustsec/audit-check/pull/23](https://github.com/rustsec/audit-check/pull/23)
- npm audit fix by
[@&#8203;tarcieri](https://github.com/tarcieri) in
[https://github.com/rustsec/audit-check/pull/24](https://github.com/rustsec/audit-check/pull/24)
- v2.0.0 release prep by
[@&#8203;tarcieri](https://github.com/tarcieri) in
[https://github.com/rustsec/audit-check/pull/25](https://github.com/rustsec/audit-check/pull/25)

#### New Contributors

- [@&#8203;clechasseur](https://github.com/clechasseur) made
their first contribution in
[https://github.com/rustsec/audit-check/pull/16](https://github.com/rustsec/audit-check/pull/16)
-
[@&#8203;tillmann-crabnebula](https://github.com/tillmann-crabnebula)
made their first contribution in
[https://github.com/rustsec/audit-check/pull/20](https://github.com/rustsec/audit-check/pull/20)
- [@&#8203;ranger-ross](https://github.com/ranger-ross) made
their first contribution in
[https://github.com/rustsec/audit-check/pull/21](https://github.com/rustsec/audit-check/pull/21)
- [@&#8203;tarcieri](https://github.com/tarcieri) made their
first contribution in
[https://github.com/rustsec/audit-check/pull/24](https://github.com/rustsec/audit-check/pull/24)

**Full Changelog**:
rustsec/audit-check@v1.4.1...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/spiraldb/vortex).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
simonsan referenced this pull request in rustic-rs/rustic_core Sep 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [rustsec/audit-check](https://github.com/rustsec/audit-check)
| action | major | `v1.4.1` -> `v2.0.0` |

---

### Release Notes

<details>
<summary>rustsec/audit-check (rustsec/audit-check)</summary>

###
[`v2.0.0`](https://github.com/rustsec/audit-check/releases/tag/v2.0.0)

[Compare
Source](https://github.com/rustsec/audit-check/compare/v1.4.1...v2.0.0)

#### What's Changed

- Run on Node 20.x by
[@&#8203;clechasseur](https://github.com/clechasseur) in
[https://github.com/rustsec/audit-check/pull/16](https://github.com/rustsec/audit-check/pull/16)
- Remove `generate-lockfile` To Prevent Overwriting Checked-In Lock
Files by
[@&#8203;tillmann-crabnebula](https://github.com/tillmann-crabnebula)
in
[https://github.com/rustsec/audit-check/pull/20](https://github.com/rustsec/audit-check/pull/20)
- Added support for `working-directory` by
[@&#8203;ranger-ross](https://github.com/ranger-ross) in
[https://github.com/rustsec/audit-check/pull/21](https://github.com/rustsec/audit-check/pull/21)
- fix: security fix for vulnerability in `braces` library by
[@&#8203;clechasseur](https://github.com/clechasseur) in
[https://github.com/rustsec/audit-check/pull/23](https://github.com/rustsec/audit-check/pull/23)
- npm audit fix by
[@&#8203;tarcieri](https://github.com/tarcieri) in
[https://github.com/rustsec/audit-check/pull/24](https://github.com/rustsec/audit-check/pull/24)
- v2.0.0 release prep by
[@&#8203;tarcieri](https://github.com/tarcieri) in
[https://github.com/rustsec/audit-check/pull/25](https://github.com/rustsec/audit-check/pull/25)

#### New Contributors

- [@&#8203;clechasseur](https://github.com/clechasseur) made
their first contribution in
[https://github.com/rustsec/audit-check/pull/16](https://github.com/rustsec/audit-check/pull/16)
-
[@&#8203;tillmann-crabnebula](https://github.com/tillmann-crabnebula)
made their first contribution in
[https://github.com/rustsec/audit-check/pull/20](https://github.com/rustsec/audit-check/pull/20)
- [@&#8203;ranger-ross](https://github.com/ranger-ross) made
their first contribution in
[https://github.com/rustsec/audit-check/pull/21](https://github.com/rustsec/audit-check/pull/21)
- [@&#8203;tarcieri](https://github.com/tarcieri) made their
first contribution in
[https://github.com/rustsec/audit-check/pull/24](https://github.com/rustsec/audit-check/pull/24)

**Full Changelog**:
rustsec/audit-check@v1.4.1...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/rustic-rs/rustic_core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiQS1kZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: simonsan <14062932+simonsan@users.noreply.github.com>
renovate bot referenced this pull request in smartive/zitadel-rust Sep 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [rustsec/audit-check](https://github.com/rustsec/audit-check)
| action | major | `v1.4.1` -> `v2.0.0` |

---

### Release Notes

<details>
<summary>rustsec/audit-check (rustsec/audit-check)</summary>

###
[`v2.0.0`](https://github.com/rustsec/audit-check/releases/tag/v2.0.0)

[Compare
Source](https://github.com/rustsec/audit-check/compare/v1.4.1...v2.0.0)

#### What's Changed

- Run on Node 20.x by
[@&#8203;clechasseur](https://github.com/clechasseur) in
[https://github.com/rustsec/audit-check/pull/16](https://github.com/rustsec/audit-check/pull/16)
- Remove `generate-lockfile` To Prevent Overwriting Checked-In Lock
Files by
[@&#8203;tillmann-crabnebula](https://github.com/tillmann-crabnebula)
in
[https://github.com/rustsec/audit-check/pull/20](https://github.com/rustsec/audit-check/pull/20)
- Added support for `working-directory` by
[@&#8203;ranger-ross](https://github.com/ranger-ross) in
[https://github.com/rustsec/audit-check/pull/21](https://github.com/rustsec/audit-check/pull/21)
- fix: security fix for vulnerability in `braces` library by
[@&#8203;clechasseur](https://github.com/clechasseur) in
[https://github.com/rustsec/audit-check/pull/23](https://github.com/rustsec/audit-check/pull/23)
- npm audit fix by
[@&#8203;tarcieri](https://github.com/tarcieri) in
[https://github.com/rustsec/audit-check/pull/24](https://github.com/rustsec/audit-check/pull/24)
- v2.0.0 release prep by
[@&#8203;tarcieri](https://github.com/tarcieri) in
[https://github.com/rustsec/audit-check/pull/25](https://github.com/rustsec/audit-check/pull/25)

#### New Contributors

- [@&#8203;clechasseur](https://github.com/clechasseur) made
their first contribution in
[https://github.com/rustsec/audit-check/pull/16](https://github.com/rustsec/audit-check/pull/16)
-
[@&#8203;tillmann-crabnebula](https://github.com/tillmann-crabnebula)
made their first contribution in
[https://github.com/rustsec/audit-check/pull/20](https://github.com/rustsec/audit-check/pull/20)
- [@&#8203;ranger-ross](https://github.com/ranger-ross) made
their first contribution in
[https://github.com/rustsec/audit-check/pull/21](https://github.com/rustsec/audit-check/pull/21)
- [@&#8203;tarcieri](https://github.com/tarcieri) made their
first contribution in
[https://github.com/rustsec/audit-check/pull/24](https://github.com/rustsec/audit-check/pull/24)

**Full Changelog**:
rustsec/audit-check@v1.4.1...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/smartive/zitadel-rust).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot referenced this pull request in rustic-rs/rustic Sep 25, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [rustsec/audit-check](https://github.com/rustsec/audit-check)
| action | major | `v1.4.1` -> `v2.0.0` |

---

### Release Notes

<details>
<summary>rustsec/audit-check (rustsec/audit-check)</summary>

###
[`v2.0.0`](https://github.com/rustsec/audit-check/releases/tag/v2.0.0)

[Compare
Source](https://github.com/rustsec/audit-check/compare/v1.4.1...v2.0.0)

#### What's Changed

- Run on Node 20.x by
[@&#8203;clechasseur](https://github.com/clechasseur) in
[https://github.com/rustsec/audit-check/pull/16](https://github.com/rustsec/audit-check/pull/16)
- Remove `generate-lockfile` To Prevent Overwriting Checked-In Lock
Files by
[@&#8203;tillmann-crabnebula](https://github.com/tillmann-crabnebula)
in
[https://github.com/rustsec/audit-check/pull/20](https://github.com/rustsec/audit-check/pull/20)
- Added support for `working-directory` by
[@&#8203;ranger-ross](https://github.com/ranger-ross) in
[https://github.com/rustsec/audit-check/pull/21](https://github.com/rustsec/audit-check/pull/21)
- fix: security fix for vulnerability in `braces` library by
[@&#8203;clechasseur](https://github.com/clechasseur) in
[https://github.com/rustsec/audit-check/pull/23](https://github.com/rustsec/audit-check/pull/23)
- npm audit fix by
[@&#8203;tarcieri](https://github.com/tarcieri) in
[https://github.com/rustsec/audit-check/pull/24](https://github.com/rustsec/audit-check/pull/24)
- v2.0.0 release prep by
[@&#8203;tarcieri](https://github.com/tarcieri) in
[https://github.com/rustsec/audit-check/pull/25](https://github.com/rustsec/audit-check/pull/25)

#### New Contributors

- [@&#8203;clechasseur](https://github.com/clechasseur) made
their first contribution in
[https://github.com/rustsec/audit-check/pull/16](https://github.com/rustsec/audit-check/pull/16)
-
[@&#8203;tillmann-crabnebula](https://github.com/tillmann-crabnebula)
made their first contribution in
[https://github.com/rustsec/audit-check/pull/20](https://github.com/rustsec/audit-check/pull/20)
- [@&#8203;ranger-ross](https://github.com/ranger-ross) made
their first contribution in
[https://github.com/rustsec/audit-check/pull/21](https://github.com/rustsec/audit-check/pull/21)
- [@&#8203;tarcieri](https://github.com/tarcieri) made their
first contribution in
[https://github.com/rustsec/audit-check/pull/24](https://github.com/rustsec/audit-check/pull/24)

**Full Changelog**:
rustsec/audit-check@v1.4.1...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/rustic-rs/rustic).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NC4zIiwidXBkYXRlZEluVmVyIjoiMzguOTQuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiQS1kZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants