Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git error message to create-wasm-app #84

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Add git error message to create-wasm-app #84

merged 4 commits into from
Jun 3, 2019

Conversation

olisolomons
Copy link

When the npm init wasm-app command fails, there are now more useful error messages to aid debugging.

When the `npm init wasm-app` command fails, there are now more useful error messages to aid debugging.
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this! Will merge with the couple suggestions below applied 👍

.bin/create-wasm-app.js Outdated Show resolved Hide resolved
.bin/create-wasm-app.js Outdated Show resolved Hide resolved
.bin/create-wasm-app.js Outdated Show resolved Hide resolved
olisolomons and others added 3 commits May 28, 2019 22:23
Co-Authored-By: Nick Fitzgerald <fitzgen@gmail.com>
Co-Authored-By: Nick Fitzgerald <fitzgen@gmail.com>
Co-Authored-By: Nick Fitzgerald <fitzgen@gmail.com>
@fitzgen fitzgen merged commit 64876e0 into rustwasm:make-npm-init-work Jun 3, 2019
@fitzgen
Copy link
Member

fitzgen commented Jun 3, 2019

Thanks again @olisolomons!

@felixf4xu
Copy link

it's merged but not into master branch.

Could you release a new version to include this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants