Migrate to Edition 2021 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing as Trunk released a new version 10 minutes ago. |
|
Can you please also update the changelog? Also, I believe this should be a minor version, not patch, when releasing, right? |
This is done. Should we add a PR template so future contributors don't forget about this?
I believe so as this pull request now requires 1.64 for all crates where as in the past only some crates require 1.64. |
Good idea! I also updated the CI so it runs against MSRV (and nightly) too. Will merge this once CI is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates to edition 2021.
Since wasm-bindgen requires 1.56, there is no benefit to keep crates at edition 2018.
Upgrading the crates to edition 2021 will enable the rust-version field which suppresses clippy for lints not available in MSRV.
I have calculated the MSRV with
cargo-msrv, which is 1.64.