Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the flags what to expect WASI targets. #425

Merged
merged 5 commits into from
Dec 10, 2023
Merged

Remove the flags what to expect WASI targets. #425

merged 5 commits into from
Dec 10, 2023

Conversation

langyo
Copy link
Contributor

@langyo langyo commented Dec 10, 2023 •
edited
Loading

@langyo langyo marked this pull request as draft December 10, 2023 02:55
@langyo

This comment was marked as outdated.

Sign in to view
@langyo langyo marked this pull request as ready for review December 10, 2023 05:14
@langyo langyo mentioned this pull request Dec 10, 2023
Merged
2 tasks
futursolo
futursolo reviewed Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally intended this to be fixed in #423, could you please update the wasm-bindgen version here?

crates/history/Cargo.toml Outdated Show resolved Hide resolved
@langyo @futursolo
Update crates/history/Cargo.toml
7cd71ba 
Co-authored-by: Kaede Hoshikawa <futursolo@users.noreply.github.com>
futursolo
futursolo approved these changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@futursolo futursolo merged commit 3193cd6 into rustwasm:master Dec 10, 2023
20 checks passed
@langyo
Copy link
Contributor Author

langyo commented Dec 10, 2023

@hamza1311 Now gloo-history should be able to release a patch version... Once the patch version is released, yew can officially start review. Could you please take a look?

@futursolo And could you please help me see if this can be merged as soon as possible? yewstack/tokise#11

The original PR is here yewstack/yew#3534

@ranile
Copy link
Collaborator

ranile commented Dec 11, 2023

Published gloo-history v0.2.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futursolo futursolo futursolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langyo @ranile @futursolo