Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install wasm-gc from crates.io #75

Merged
merged 1 commit into from
Mar 3, 2018
Merged

Install wasm-gc from crates.io #75

merged 1 commit into from
Mar 3, 2018

Conversation

josmardias
Copy link
Contributor

@josmardias josmardias commented Mar 2, 2018

This PR updates setup.md to install wasm-gc from crates.io, instead of from git

@josmardias
Copy link
Contributor Author

Already updated wasm-gc docs to install from creates.io as well
alexcrichton/wasm-gc/pull/16

@mgattozzi
Copy link
Contributor

Hey @josmardias thanks for keeping track of this and updating the docs accordingly! This is great!

Would you mind also updating the docs here as well so we can keep the rust-wasm book up to date as well? Once you do that let's get this PR merged! :D

@josmardias
Copy link
Contributor Author

Sure! Good catch!

@josmardias
Copy link
Contributor Author

Oh wait. I'm confused.
Isn't that exactly the file I'm changing on this PR? 😕

Sorry if I'm getting it wrong

@josmardias
Copy link
Contributor Author

josmardias commented Mar 3, 2018

Did a little search here for cargo install.
Didn't find other relevant occurrences
image


built rust-wasm book here:
image

Should I open a PR to gh-pages as well or CI will take care of that?

@josmardias
Copy link
Contributor Author

josmardias commented Mar 3, 2018

I realized that I didn't explained myself properly on the PR description, so I edited it to make it try to make it clear what I'm doing on this PR.

@mgattozzi
Copy link
Contributor

Oh @josmardias I thought this was the README.md file for some reason. You're right. It's been a long week to say the least 😅 This is perfect actually. You did nothing wrong here. The CI will build the book so you don't need to worry about that. Thanks again!

@mgattozzi mgattozzi merged commit b995e28 into rustwasm:master Mar 3, 2018
@josmardias josmardias deleted the wasm-gc-crates-io branch March 3, 2018 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants