Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twiggy paths should work with regexes #58

Closed
fitzgen opened this issue May 11, 2018 · 4 comments
Closed

twiggy paths should work with regexes #58

fitzgen opened this issue May 11, 2018 · 4 comments
Assignees
@data-pup
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@fitzgen
Copy link
Member

fitzgen commented May 11, 2018

It can be annoying to specify the whole item name, including the hash at the end. We should support doing just my_crate::.* etc.
@fitzgen fitzgen added enhancement New feature or request help wanted Extra attention is needed labels May 11, 2018
@fitzgen fitzgen mentioned this issue May 11, 2018
Merged
@data-pup
Copy link
Member

I can start working on this one when I am done working on #57!

@data-pup data-pup self-assigned this May 18, 2018
@data-pup
Copy link
Member

Now that #63 landed, I can start looking into this issue. Any advice on getting the regexes working is welcome, I figure the process here will end up looking very similar to whatever we need to do to get #59 fixed too.

@fitzgen
Copy link
Member Author

fitzgen commented May 18, 2018

The regex crate is a joy to work with :)

data-pup added a commit to data-pup/twiggy that referenced this issue May 22, 2018
@data-pup
Added a --regex option to twiggy paths. Items can now be specified
9791121 
by regex rather than exact name. Solves rustwasm#58.
@data-pup data-pup mentioned this issue May 22, 2018
Merged
data-pup added a commit to data-pup/twiggy that referenced this issue May 22, 2018
@data-pup
Added a --regex option to twiggy paths. Items can now be specified
a36eac7 
by regex rather than exact name. Solves rustwasm#58.
@data-pup
Copy link
Member

Solved in #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@data-pup data-pup

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fitzgen @data-pup