Skip to content

Commit

Permalink
Support multi-value JS engines (#1863)
Browse files Browse the repository at this point in the history
This commit adds support to wasm-bindgen to run over interface
types-enabled modules that use multi-value returns and returns are
loaded from the returned array rather than from memory.
  • Loading branch information
alexcrichton authored Nov 19, 2019
1 parent 8513900 commit e934a0f
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
19 changes: 16 additions & 3 deletions crates/cli-support/src/js/binding.rs
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,22 @@ impl<'a, 'b> Builder<'a, 'b> {
}
}

// No return pointer? That's much easier! We just have one input
// of `ret` which is created in the JS shim below.
None => ret_args.push("ret".to_string()),
// No return pointer? That's much easier!
//
// If there's one return value we just have one input of `ret`
// which is created in the JS shim below. If there's multiple
// return values (a multi-value module) then we'll pull results
// from the returned array.
None => {
let amt = self.cx.module.types.get(binding.wasm_ty).results().len();
if amt == 1 {
ret_args.push("ret".to_string());
} else {
for i in 0..amt {
ret_args.push(format!("ret[{}]", i));
}
}
}
}
js = JsBuilder::new(ret_args);
let mut ret = outgoing::Outgoing::new(self.cx, &mut js);
Expand Down
2 changes: 1 addition & 1 deletion crates/cli-support/src/wasm2es6js.rs
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ pub fn typescript(module: &Module) -> Result<String, Error> {
ret = match ty.results().len() {
0 => "void",
1 => "number",
_ => bail!("cannot support multi-return yet"),
_ => "Array",
},
));
}
Expand Down

0 comments on commit e934a0f

Please sign in to comment.