Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-sys omits DataView members when generating code from IDLs #2312

Closed
qdot opened this issue Sep 19, 2020 · 0 comments
Closed

web-sys omits DataView members when generating code from IDLs #2312

qdot opened this issue Sep 19, 2020 · 0 comments
Labels
bug

Comments

@qdot
Copy link
Contributor

qdot commented Sep 19, 2020

Describe the Bug

With the WebBluetooth IDL landed into unstable, web-sys is now generating WebBluetooth rust accessible code. However, some members from the spec are missing since it seems to be the only spec that uses DataView as an IDL type.

Steps to Reproduce

  1. Generate web-sys features using unstable config
  2. Check generated BluetoothRemoteGATTCharacteristic code

Expected Behavior

The value member of BluetoothRemoteGATTCharacteristic is generated as part of the file

Actual Behavior

value does not exist as a member of the generated rust code.

Additional Context

I'll see if I can handle this, since it's in the IDL I submitted and that seems to be the only IDL currently in the system that does this.
@qdot qdot added the bug label Sep 19, 2020
qdot pushed a commit to qdot/wasm-bindgen that referenced this issue Sep 20, 2020
@grabango-km
Add Dataview as a valid attribute type for WebIDL Codegen
15fb665 
Some WebIDL specs (WebBluetooth, WebUSB, etc) use DataView as an
attribute type. These attributes should map to a js_sys::DataView type.

Fixes rustwasm#2312
qdot added a commit to qdot/wasm-bindgen that referenced this issue Sep 20, 2020
@qdot
Add Dataview as a valid attribute type for WebIDL Codegen
a5330c0 
Some WebIDL specs (WebBluetooth, WebUSB, etc) use DataView as an
attribute type. These attributes should map to a js_sys::DataView type.

Fixes rustwasm#2312
qdot added a commit to qdot/wasm-bindgen that referenced this issue Sep 20, 2020
@qdot
Add Dataview as a valid attribute type for WebIDL Codegen
68519c0 
Some WebIDL specs (WebBluetooth, WebUSB, etc) use DataView as an
attribute type. These attributes should map to a js_sys::DataView type.

Fixes rustwasm#2312
qdot added a commit to qdot/wasm-bindgen that referenced this issue Sep 20, 2020
@qdot
Add Dataview as a valid attribute type for WebIDL Codegen
4b9d1f3 
Some WebIDL specs (WebBluetooth, WebUSB, etc) use DataView as an
attribute type. These attributes should map to a js_sys::DataView type.

Fixes rustwasm#2312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qdot