Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unforgeable attributes need to be #[wasm_bindgen(structural)] #432

Closed
fitzgen opened this issue Jul 9, 2018 · 1 comment
Closed

Unforgeable attributes need to be #[wasm_bindgen(structural)] #432

fitzgen opened this issue Jul 9, 2018 · 1 comment
Labels
frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen

Comments

@fitzgen
Copy link
Member

fitzgen commented Jul 9, 2018

https://heycam.github.io/webidl/#Unforgeable

If the [Unforgeable] extended attribute appears on regular attributes or non-static operations, it indicates that the attribute or operation will be reflected as an ECMAScript property in a way that means its behavior cannot be modified and that performing a property lookup on the object will always result in the attribute’s property value being returned. In particular, the property will be non-configurable and will exist as an own property on the object itself rather than on its prototype.

Emphasis mine.

This is currently breaking my tests for #409 so I might fix it in that PR. Filing for posterity though.
@fitzgen fitzgen added the frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen label Jul 9, 2018
fitzgen added a commit to fitzgen/wasm-bindgen that referenced this issue Jul 9, 2018
@fitzgen
webidl: Convert [Unforgeable] attributes into `#[wasm_bindgen(structu…
16ea94c 
…ral)]`

Fixes rustwasm#432
@fitzgen
Copy link
Member Author

fitzgen commented Jul 9, 2018

This is currently breaking my tests for #409 so I might fix it in that PR.

Fix for this is in that PR.

@fitzgen fitzgen closed this as completed in f2f2d72 Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend:webidl Issues related to the WebIDL frontend to wasm-bindgen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen