-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test TypeScript output on CI #922
Comments
A great idea! The following issue contains some instructions on how to get async loading working with TypeScript and Webpack, which would allow testing the entire compilation process from end-to-end: rustwasm/rust-webpack-template#43 |
And as mentioned in that issue, if you'd like, I can try to take a look at setting up an example TypeScript+Rust+Webpack project which can be built using |
A nice idea! I think it's good to have a test like that but for this repository we can probably just stick to the vanilla typescript compiler and a sample project I'd be wary of coupling to too many things outside of wasm bindgens control |
My recent experience is that if I just check run In a perfect world, something would run Still, I'd love for What would be the most useful way for me to approach this goal? |
Oh well I think the priority here is getting something tested, so I'm fine getting that done however and then we can tweak it as necessary! |
This commit starts to add some simple tests for our TypeScript output of the wasm-bindgen CLI, currently just running `tsc` to make sure syntax looks good and types are emitted as expected. This'll hopefully be able to get expanded over time with bug reports as they come in as well as ensure that we don't regress anything in egregious manners! Closes rustwasm#922
This commit starts to add some simple tests for our TypeScript output of the wasm-bindgen CLI, currently just running `tsc` to make sure syntax looks good and types are emitted as expected. This'll hopefully be able to get expanded over time with bug reports as they come in as well as ensure that we don't regress anything in egregious manners! Closes rustwasm#922
This commit starts to add some simple tests for our TypeScript output of the wasm-bindgen CLI, currently just running `tsc` to make sure syntax looks good and types are emitted as expected. This'll hopefully be able to get expanded over time with bug reports as they come in as well as ensure that we don't regress anything in egregious manners! Closes rustwasm#922
There have been a number of TypeScript-related regressions recently like #917, and while we used to test TypeScript on CI we no longer do! We should figure out how to set up a dedicated builder focused on testing the TypeScript output of wasm-bindgen!
The text was updated successfully, but these errors were encountered: