Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update typescript generation to reflect that Option<T> can be undefined #1008

Merged
merged 1 commit into from
Nov 5, 2018
Merged

update typescript generation to reflect that Option<T> can be undefined #1008

merged 1 commit into from
Nov 5, 2018

Conversation

henriiik
Copy link
Contributor

@henriiik henriiik commented Nov 4, 2018

This patch solves issue #982

sendilkumarn
sendilkumarn approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@sendilkumarn sendilkumarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henriiik

Congrats on your first contribution 🎉

@sendilkumarn sendilkumarn merged commit 3c31a32 into rustwasm:master Nov 5, 2018
@henriiik
Copy link
Contributor Author

henriiik commented Nov 5, 2018

Thanks! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sendilkumarn sendilkumarn sendilkumarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henriiik @sendilkumarn