Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple small improvements #1235

Merged
merged 2 commits into from
Feb 11, 2019
Merged

A couple small improvements #1235

merged 2 commits into from
Feb 11, 2019

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Feb 10, 2019

  • Use unwrap_throw instead of normal unwrap for JsString -> String conversion
  • Don't give up when servers don't set the application/wasm MIME type

@fitzgen
Use unwrap_throw instead of normal unwrap for JsString -> String …
c8ad85d 
…conversion

Should have less code size.
@fitzgen
Don't give up when servers don't set the application/wasm MIME type
4975ca2 
It is quite annoying when using `python -m SimpleHTTPServer` or equivalent.
@fitzgen fitzgen requested a review from alexcrichton February 10, 2019 19:01
@alexcrichton alexcrichton merged commit 311dafd into rustwasm:master Feb 11, 2019
@fitzgen fitzgen deleted the some-little-things branch February 11, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fitzgen @alexcrichton