Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an assert while deleting table elements #1274

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Fix an assert while deleting table elements #1274

merged 1 commit into from
Feb 19, 2019

Commits on Feb 19, 2019

  1. Fix an assert while deleting table elements 

    LLVM's mergefunc pass may mean that the same descriptor function is used
for different closure invocation sites even when the closure itself is
different. This typically only happens with LTO but in theory could
happen at any time!

The assert was tripping when we tried to delete the same function table
entry twice, so instead of a `Vec<usize>` of entries to delete this
commit switches to a `HashSet<usize>` which should do the deduplication
for us and enusre that we delete each descriptor only once.

Closes rustwasm#1264
    @alexcrichton
    alexcrichton committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    9bab9d4 View commit details
    Browse the repository at this point in the history