Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up passing ASCII-only strings to WASM #1470

Merged
merged 4 commits into from
May 13, 2019
Merged

Speed up passing ASCII-only strings to WASM #1470

merged 4 commits into from
May 13, 2019

Commits on May 10, 2019

  1. Speed up passing ASCII-only strings to WASM 

    Some speed up numbers from my string-heavy WASM benchmarks:
 - Firefox + encodeInto: +45%
 - Chrome + encodeInto: +80%
 - Firefox + encode: +29%
 - Chrome + encode: +62%

Note that this helps specifically with case of lots of small ASCII strings, in case of large strings there is no measurable difference in either direction.
    @RReverser
    RReverser committed May 10, 2019
    Configuration menu
    Copy the full SHA
    57b1a57 View commit details
    Browse the repository at this point in the history

  2. Reduce reallocation sizes

    @RReverser
    RReverser committed May 10, 2019
    Configuration menu
    Copy the full SHA
    7418cec View commit details
    Browse the repository at this point in the history

  3. Fix offset to arg comparison

    @RReverser
    RReverser committed May 10, 2019
    Configuration menu
    Copy the full SHA
    0c681ee View commit details
    Browse the repository at this point in the history

Commits on May 13, 2019

  1. Add a debug assert and more tests

    @alexcrichton
    alexcrichton committed May 13, 2019
    Configuration menu
    Copy the full SHA
    15defcf View commit details
    Browse the repository at this point in the history