Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist send_with_u8_array slice #2015

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Whitelist send_with_u8_array slice #2015

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7810b73
Whitelist send_with_u8_array slice
chinedufn Feb 27, 2020
001f4b0
Fix send slice
chinedufn Feb 28, 2020
6684987
Remove chromedriver comment
chinedufn Feb 28, 2020
638bd6f
Get slice tests running in CI
chinedufn Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/webidl/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@ fn immutable_slice_whitelist() -> BTreeSet<&'static str> {
"clearBufferfv",
"clearBufferiv",
"clearBufferuiv",
// WebSocket
"send_with_u8_array",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure but I think it requires camelCase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah it looks like the others are all camel-case here. @chinedufn mind testing this out locally to see if it had the desired effect on the method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! chinedufn@001f4b0#diff-266f7f5e4a4a2bbbf9377f3d19673606R95-R98

// TODO: Add another type's functions here. Leave a comment header with the type name
])
}
Expand Down