Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raytracing example browser support #2083

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

chinedufn
Copy link
Contributor

Raytracing example works fine for me on Chrome 80

@bennetthardwick
Copy link
Contributor

According to MDN SharedArrayBuffer has been available in Chrome / Chromium since version 68.

@chinedufn
Copy link
Contributor Author

Yo!

It's not just SharedArrayBuffer that's required. Also needs an implementation of the WebAssembly threads proposal.

For example, in Chrome 70 it was behind a flag.

image

via - https://developers.google.com/web/updates/2018/10/wasm-threads

@chinedufn
Copy link
Contributor Author

chinedufn commented Apr 16, 2020

According to https://www.chromestatus.com/feature/5724132452859904 worked based threads have been enabled by default since Chrome 74 but I don't recall the demo working back then.

Definitely works in 80, might work in 79 but I don't remember if I tried on 79 and didn't take the time to try when I made this PR.

@chinedufn
Copy link
Contributor Author

Updated the wording to remove the version number so that I don't have to go through and check when the demo started working.

This demo may also break over time as Firefox updates, but we'll try to keep it
* Firefox Nightly
- `SharedArrayBuffer` is enabled in `about:config` in Firefox
- This demo may also break over time as Firefox updates, but we'll try to keep it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed now as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed This demo may also break over time as Firefox updates, but we'll try to keep it

Didn't remove the shared array buffer bit since my Firefox 75 can't run the demo (I don't have any flags enabled)

@alexcrichton
Copy link
Contributor

👍

@alexcrichton alexcrichton merged commit f7f4799 into rustwasm:master Apr 16, 2020
@chinedufn chinedufn deleted the patch-1 branch April 16, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants