-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update raytracing example browser support #2083
Conversation
According to MDN |
Yo! It's not just For example, in Chrome 70 it was behind a flag. via - https://developers.google.com/web/updates/2018/10/wasm-threads |
According to https://www.chromestatus.com/feature/5724132452859904 worked based threads have been enabled by default since Chrome 74 but I don't recall the demo working back then. Definitely works in 80, might work in 79 but I don't remember if I tried on 79 and didn't take the time to try when I made this PR. |
Updated the wording to remove the version number so that I don't have to go through and check when the demo started working. |
guide/src/examples/raytrace.md
Outdated
This demo may also break over time as Firefox updates, but we'll try to keep it | ||
* Firefox Nightly | ||
- `SharedArrayBuffer` is enabled in `about:config` in Firefox | ||
- This demo may also break over time as Firefox updates, but we'll try to keep it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed now as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed This demo may also break over time as Firefox updates, but we'll try to keep it
Didn't remove the shared array buffer bit since my Firefox 75 can't run the demo (I don't have any flags enabled)
👍 |
Raytracing example works fine for me on Chrome 80