New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2089 #2090

Merged

alexcrichton merged 1 commit into rustwasm:master from a1trl9:a1trl9/global_import_case_fix

Apr 20, 2020

Contributor

a1trl9 commented Apr 18, 2020

Fix #2089.

The case provided there could be reduced to:

use wasm_bindgen::prelude::*;

#[wasm_bindgen(module = vscode)]
extern "C" {
    #[wasm_bindgen(js_namespace = window)]
    fn f1();
}

#[wasm_bindgen]
extern "C" {
    type window;

    #[wasm_bindgen(getter, static_method_of = window)]
    fn f2();
}

#[wasm_bindgen]
pub fn yoyo() {
    f1();
    window::f2();
}

Seems prestore_global_import_identifiers didn't exhaustively match all possible JsImport so that StructuralClassGetter doesn't work here.

A test added.


          exhausively match JSImportName

1acd5d9

alexcrichton merged commit 3c40492 into rustwasm:master

Contributor

alexcrichton commented Apr 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet