Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the code generation for catch #2098

Merged
merged 5 commits into from
Apr 22, 2020

Conversation

Pauan
Copy link
Contributor

@Pauan Pauan commented Apr 21, 2020

Right now every catch function generates the minified wrapper try{}catch(e){h(e)}. This PR changes it so that it now generates the minified wrapper h(). This saves 16 bytes per catch function.

I did benchmark tests, the performance was identical (any differences seemed to be noise).

@alexcrichton
Copy link
Contributor

Nice idea!

@alexcrichton alexcrichton merged commit 7bc9147 into rustwasm:master Apr 22, 2020
@Pauan Pauan deleted the improved-catch branch April 23, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants