add reverse mappings from value to name on enums exported from rust/wasm #2240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds reverse mappings to enums exported from Rust, so that the string corresponding to a particular integer value can be obtained easily. This matches what TypeScript does for enums defined directly by TypeScript code.
I’ve updated the corresponding tests to take this into account.
This goes some way towards resolving #2045, albeit the approach is still a little different - I’ve kept the
Object.freeze
call that wasm-bindgen performs on its enums (whereas TypeScript does not seem to return a frozen object at all). Here’s an example of how they compare:Nevertheless, having reverse mappings still makes it more compatible with TypeScript code.