Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help Needed] Implement error handling #2463

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Roba1993
Copy link

What is this about

This PR is trying to support error handling within wasm-bindgen.
This is especially needed if a library is created with wasm-bindgen, which is then used in the browser as well as in a rust executable.

Related Issues & PRs

Following issues are related to this PR:

There was already the PR #1173 which has addressed this issue.
At that time the PR has been closed, because failure::Error doesn't implement std::error::Error.
This problem should not exist anymore, because failure::Error is deprecated.

Support needed

I took the original implementation from #1173 and created this PR for it. @RReverser, I hope this is okay for you.
Unfortunately I don't understand wasm-bindgen enough to correctly handle the __wbindgen_error_new adapter.
This part of the source code has changed so much, that I need support to finish this implementation.

@RReverser
Copy link
Member

@RReverser, I hope this is okay for you.

TBH I'd prefer if you cherry-picked the commit and made your modifications on top of it in follow-up commits - otherwise it loses authorship information.

@Roba1993
Copy link
Author

@RReverser I can close this PR if you want, would you then create a new one? I didn't been able to pull that off in the right way :/

@RReverser
Copy link
Member

@Roba1993 Nah, don't close it. What you can do is edit the commit message (via git commit --amend) to include extra Co-Authored-By: Ingvar Stepanyan <me@rreverser.com> line in the end - Github will recognise that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants