Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing APIs for InputEvent #2499

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Add missing APIs for InputEvent #2499

merged 3 commits into from
Mar 25, 2021

Conversation

lunabunn
Copy link
Contributor

@lunabunn lunabunn commented Mar 17, 2021 •
edited
Loading

Fix #2489.

@lunabunn lunabunn marked this pull request as ready for review March 18, 2021 00:00
@lunabunn lunabunn closed this Mar 24, 2021
@lunabunn lunabunn reopened this Mar 24, 2021
@lunabunn
Copy link
Contributor Author

I got the WebIDL definitions from https://hg.mozilla.org/mozilla-central/file/tip/dom/webidl/InputEvent.webidl, is that the right thing to do?

@lunabunn lunabunn changed the title Add data field to InputEvent Add missing APIs for InputEvent Mar 24, 2021
@alexcrichton
Copy link
Contributor

That's what we've done historically, yeah, thanks!

@alexcrichton alexcrichton merged commit 0cec406 into rustwasm:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web_sys::InputEvent missing important fields
2 participants
@lunabunn @alexcrichton