Make navigator.clipboard fallible #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigator.clipboardis currently, in line with the official IDL, infallible:wasm-bindgen/crates/web-sys/webidls/unstable/Clipboard.webidl
Lines 18 to 20 in b2caf83
In practise though it is fallible, at least in firefox and edge it's undefined on non-HTTPS sites.
I went ahead and made this PR to change to
Clipboard? clipboard, while also bumping the IDL used from 5 June 2019's spec to 4 June 2021's.Let me know if there's a better approach to resolving this! Also if someone could confirm the removal of
ClipboardEvent::{new,new_with_event_init_dict}are expected?