Improve TypedArray::to_vec performance by not zero-initializing buffer #2650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see the rationale and results in #2639 .
Changes:
raw_copy_to
to take pointers instead of slices (as slices require data to be pre-initialized)unsafe
, as even though technically we don't use any unsafe APIs, invalid use can modify random memorypub
(this part is optional, let me know if you don't want this PR to extend public API)to_vec()
. The general pattern ofwith_capacity->modify through pointer->set_len
is similar to the official example in https://doc.rust-lang.org/std/vec/struct.Vec.html#method.set_len , and looks sound in general. Still, this does add a significant amount ofunsafe
uses.