Implement ImageBitmapOptions
#3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
image-bitmap-options
branch
from
dd4303f
to
523e98d
Compare
daxpedda
force-pushed
the
image-bitmap-options
branch
from
523e98d
to
b506b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the WHATWG Spec.
Adding an optional at the end was a problem because the current IDL generator will change the function name because of an overlapping second argument between functions. This cannot be fixed because it would affect all other functions.
So I opted to just implement a new table that does post-fixes, I assume this will be useful for other additions in the future.
WebIDL references:
https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope-mixin:dom-createimagebitmap
https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#imagebitmapoptions