-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Fixed size array support #3458
base: main
Are you sure you want to change the base?
Conversation
Thanks @daxpedda! The one thing that slightly concerns me is passing the array directly. Technically that wouldn't be FFI safe in C, but it seems to work at least for now. No guarantees that it continues to do so though. I messed around with trying to pass a single raw pointer back and forth (which might actually be more performant if we convert to JS TypedArrays). Might see if I can get that working. Would result in us not needing to make any changes to the xformer I think. |
I wouldn't feel comfortable enough reviewing something not FFI safe, so that's definitely preferable. |
No description provided.