Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bindings and comments for Atomics.wait #3509

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fix bindings and comments for Atomics.wait #3509

merged 2 commits into from
Jul 5, 2023

Conversation

allsey87
Copy link
Contributor

@allsey87 allsey87 commented Jul 5, 2023

@daxpedda @hamza1311 as discussed in #3504, this PR fixes the bindings and comments for Atomics.wait.

daxpedda
daxpedda requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the small nit.
Thank you.

CHANGELOG.md Outdated Show resolved Hide resolved
@allsey87 allsey87 requested a review from daxpedda July 5, 2023 20:37
daxpedda
daxpedda approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit 37bebc8 into rustwasm:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allsey87 @daxpedda