-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace curl package into ureq #3511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good solution in the meantime but, ultimately we should just replace curl with ureq.
I'm afraid that removing the features in the future could end being a breaking change
@kerryeon would you be willing to rip out cURL entirely and just switch to A note in the changelog would also be appreciated. |
Ok, let me dig in this migration job and notify it. |
@hamza1311 @daxpedda Hello, please review when you have time :) |
- Add rustls-tls support for wasm-bindgen-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll merge this once the CI is finished
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, a couple of nits here and there.
Co-authored-by: daxpedda <daxpedda@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits.
Co-authored-by: daxpedda <daxpedda@gmail.com>
Confirmed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
When installing
wasm-bindgen-cli
in Alpine Linux, it's forced to installopenssl-sys
package.But I found that the
openssl
dependency is only subject tocurl
package, which is used for headless operations.So I think it's ok to adopt
rustls
instead, not installing the native openssl binaries by option.And I replaced the old
curl
package intoureq
, usingrustls
by default.Therefore, this PR is a
rustls
support forwasm-bindgen-cli
.