Handle raw identifiers in wasm_bindgen_test macro #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the use of raw identifiers in test names produces an invalid function name. `Ident::new` panics whenever it encounters the `r#` prefix, instead `Ident::new_raw` should be used. However, the `__wbgt` prefix we append helps form a valid identifier already. So removing the "r#" prefix is the only thing required. Fixes rustwasm#3288 Signed-off-by: Oliver T <geronimooliver00@gmail.com>
daxpedda
requested changes
Aug 4, 2023
|
A note in the changelog would be appreciated as well. |
Signed-off-by: Oliver T <geronimooliver00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the use of raw identifiers in test names produces an invalid function name.
Ident::newpanics whenever it encounters ther#prefix, insteadIdent::new_rawshould be used.However, the
__wbgtprefix we append forms a valid identifier already. So removing the raw ident prefix ("r#") is the only thing required to create a valid function name.Fixes #3288