Add bindings for CanvasTransform.setTransform(DOMMatrix2DInit)
#3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
set-transform-dom-matrix-2d
branch
from
59b46cd
to
eb61305
Compare
Liamolucko
reviewed
Aug 29, 2023
| pub fn set_transform(this: &CanvasPattern, matrix: &SvgMatrix); | ||
| pub fn set_transform_with_default_dom_matrix_2d_init(this: &CanvasPattern, matrix: &SvgMatrix); |
There was a problem hiding this comment.
This is a breaking change (and not really a desirable one, either).
I can see what happened here: you used FIXED_INTERFACES to prevent CanvasRenderingContext2d::set_transform being changed to mean the DomMatrix overload with its default value, but that affected this method too since it doesn't distinguish between methods on different types.
I think FIXED_INTERFACES will have to be extended to allow specifying both the type name and method name to fix this.
There was a problem hiding this comment.
Damn, I missed that somehow ... thank you @Liamolucko.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title.
See:
MDN
WHATWG spec (Firefox WebIDL)
Geometry Interfaces
Fixes #3578.