Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReadableStreamByobReader::read_with_u8_array() #3582

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

daxpedda
Copy link
Collaborator

See #3579.

This is technically a breaking change, but seeing as this would always fail it seems fine to me. We could always deprecate it instead.
@Liamolucko WDYT?

Copy link
Collaborator

@Liamolucko Liamolucko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm fine with removing it.

Implementation-wise, I think [RustNotWasmMemory] should probably apply to BufferSource as well, although it doesn't actually matter right now since it's only used on one API.

@daxpedda daxpedda merged commit 865923b into rustwasm:main Aug 29, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants